[ovs-dev] [PATCH] configure: Enable OpenSSL support by default.

Ben Pfaff blp at nicira.com
Thu Aug 26 20:27:08 UTC 2010


On Wed, Aug 25, 2010 at 03:36:23PM -0700, Justin Pettit wrote:
> On Aug 20, 2010, at 11:26 AM, Ben Pfaff wrote:
> 
> > -     [AC_HELP_STRING([--enable-ssl], 
> > -                     [Enable ssl support (requires libssl)])],
> > +     [AC_HELP_STRING([--disable-ssl], [Disable OpenSSL support])],
> >      [case "${enableval}" in
> >         (yes) ssl=true ;;
> >         (no)  ssl=false ;;
> >         (*) AC_MSG_ERROR([bad value ${enableval} for --enable-ssl]) ;;
> 
> Did you want to change this message to "disable-ssl"?  Shouldn't the
> results of those "(yes)" and "(no)" cases be reversed in the case of
> disabling something?

AC_ARG_ENABLE always creates both --enable-* and --disable-* options.
If you specify the --disable version then it is treated as if you
specified --enable-*=no.  I decided to only document the --disable
version, since it's more likely to be useful (for users with buggy
OpenSSL).

Here's what the Autoconf manual says:

       The user can give an argument by following the feature name with `='
    and the argument.  Giving an argument of `no' requests that the feature
    _not_ be made available.  A feature with an argument looks like
    `--enable-debug=stabs'.  If no argument is given, it defaults to `yes'.
    `--disable-FEATURE' is equivalent to `--enable-FEATURE=no'.

> My tree shows that "debian/rules" still passes in "--enable-ssl".  Did
> you want to remove that?

I want it there, because specifying --enable-ssl explicitly makes
configure fail if OpenSSL is not available.  I always want the Debian
packages to support SSL.




More information about the dev mailing list