[ovs-dev] [runt-flows 7/8] datapath: Fix default value of skb transport_header.

Ben Pfaff blp at nicira.com
Fri Aug 27 20:24:10 UTC 2010


On Fri, Aug 27, 2010 at 12:47:41PM -0700, Jesse Gross wrote:
> On Fri, Aug 27, 2010 at 12:42 PM, Ben Pfaff <blp at nicira.com> wrote:
> > On Thu, Aug 26, 2010 at 03:03:20PM -0700, Jesse Gross wrote:
> >> On Fri, Aug 13, 2010 at 10:55 AM, Ben Pfaff <blp at nicira.com> wrote:
> >> > @@ -353,7 +364,7 @@ int flow_extract(struct sk_buff *skb, u16 in_port, struct odp_flow_key *key)
> >> >                        }
> >> >                }
> >> >        } else {
> >> > -               skb_reset_transport_header(skb);
> >> > +               skb->transport_header = skb->network_header;
> >> >        }
> >>
> >> We never set the transport header if we have a valid ARP header.  I
> >> don't think it's necessary but then that makes me wonder why this is
> >> necessary.
> >
> > You're right.  Some actions do care about it for IP, but nothing cares
> > about it in other cases, so I just dropped the "else".
> >
> > Here's the new version:
> 
> Looks good.  For the record, the transport header is initialized to
> the same value as the network header in netif_receive_skb() so in the
> cases where we don't set it to something else we actually get the same
> value as if we reset it.

Thanks.

I pushed out this series.




More information about the dev mailing list