[ovs-dev] [PATCH 5/5] xenserver: Add monitor-external-ids daemon
blp at nicira.com
Fri Aug 27 21:16:51 UTC 2010
On Fri, Aug 27, 2010 at 02:13:40PM -0700, Reid Price wrote:
> Sorry for the post-push comment, took a look over it, seems reasonable
> enough. One question:
> + while True:
> + if not idl.run():
> + continue
> + <other stuff>
> + ...
> I think idl.run is a fairly fast check itself, will this tight of a loop
> burn a lot of cycles?
Yeah, that was just buggy. I pushed a fix yesterday morning.
> If so, I'll use my winnings to purchase one xen-optimization nitpick =)
> + for n in session.xenapi.network.get_all():
> + rec = session.xenapi.network.get_record(n)
> You can use session.xenapi.network.get_all_records(), since you don't use
> the reference directly anyways.
More information about the dev