[ovs-dev] [patch] datapath: Don't print VERSION BUILDNR

Simon Horman horms at verge.net.au
Tue Aug 31 01:39:36 UTC 2010


BUILDNR doesn't seem appropriate for in-tree kernel code.
I'm not sure if we want a module version number or not,
I advocate not as in-tree kernel code already has
the version of the kernel.

Signed-off-by: Simon Horman <horms at verge.net.au>

--- 

* I'm happy to carry this change outside of the openvswitch tree
  if it is preferred.

* Compile tested only
Index: openvswitch/datapath/datapath.c
===================================================================
--- openvswitch.orig/datapath/datapath.c	2010-08-31 10:34:35.000000000 +0900
+++ openvswitch/datapath/datapath.c	2010-08-31 10:35:45.000000000 +0900
@@ -2369,7 +2369,7 @@ static int __init dp_init(void)
 
 	BUILD_BUG_ON(sizeof(struct ovs_skb_cb) > sizeof(dummy_skb->cb));
 
-	printk("Open vSwitch %s, built "__DATE__" "__TIME__"\n", VERSION BUILDNR);
+	printk(KERN_INFO "Open vSwitch switching datapath\n");
 
 	err = flow_init();
 	if (err)




More information about the dev mailing list