[ovs-dev] [ofp-print 00/15] bug fixes and ofp-print improvements

Ben Pfaff blp at nicira.com
Tue Dec 14 20:23:14 UTC 2010


This series starts out with a number of bug fixes for problems I
noticed while preparing it.  The rest of the changes are improvements
to the output when formatting OpenFlow and Nicira extension messages.
Finally, I add a bunch of tests to make sure that the formatting does
not change unexpectedly in the future.

Ben Pfaff (15):
  ofproto: Fix write-after-free error in compose_nx_flow_removed().
  ofp-util: Fix encoding of NXST_AGGREGATE requests.
  ofproto: Fix encoding of NXST_* replies.
  ofproto: Always use xid 0 for *_FLOW_REMOVED messages.
  ofp-util: Use proper format specifier for uint32_t in
    ofputil_lookup_openflow_message().
  ofp-util: Improve error log messages.
  classifier: Use OFP_DEFAULT_PRIORITY instead of literal 32768.
  classifier: Insert commas after fields that lacked them in
    cls_rule_format().
  ofp-print: Always print priority exactly once.
  ofp-print: Improve formatting for bad OpenFlow messages.
  Automatically extract error types and codes for formatting.
  ofp-print: Print fragment handling in OpenFlow switch config
    messages.
  ofp-print: Insert missing whitespace.
  ofp-print: Add tests for OpenFlow message formatting.
  nx-match: Print register values in hex in "load" action also.

 build-aux/extract-ofp-errors  |  225 +++++++++++
 include/openflow/nicira-ext.h |    4 +-
 lib/.gitignore                |    1 +
 lib/automake.mk               |   10 +
 lib/classifier.c              |   14 +-
 lib/nx-match.c                |    2 +-
 lib/ofp-errors.h              |   28 ++
 lib/ofp-print.c               |  200 +++-------
 lib/ofp-util.c                |  124 ++++++-
 lib/ofp-util.h                |    7 +-
 ofproto/ofproto.c             |   10 +-
 tests/automake.mk             |    1 +
 tests/ofp-print.at            |  889 +++++++++++++++++++++++++++++++++++++++++
 tests/ofproto.at              |    8 +-
 tests/ovs-ofctl.at            |    2 +-
 tests/testsuite.at            |    1 +
 utilities/ovs-ofctl.c         |   14 +
 17 files changed, 1378 insertions(+), 162 deletions(-)
 create mode 100755 build-aux/extract-ofp-errors
 create mode 100644 lib/ofp-errors.h
 create mode 100644 tests/ofp-print.at





More information about the dev mailing list