[ovs-dev] [tun_id64 2/4] datapath: Change vals[] in struct port_lookup_key into discrete members.

Jesse Gross jesse at nicira.com
Wed Dec 1 23:11:13 UTC 2010


On Tue, Nov 30, 2010 at 5:16 PM, Ben Pfaff <blp at nicira.com> wrote:
> The 'vals' array is only convenient for use by port_hash().  It's a
> liability otherwise, since it makes the code wider and harder to read and
> seems to me less amenable to compiler optimization.
>
> In an upcoming patch the key needed in struct port_lookup_key will
> increase in size to 64 bits, so that using an array of u32 becomes even
> more problematic.  Therefore, this commit gets rid of the array in favor
> of discrete named members that carry the same information.
>
> Signed-off-by: Ben Pfaff <blp at nicira.com>

Acked-by: Jesse Gross <jesse at nicira.com>




More information about the dev mailing list