[ovs-dev] [PATCH 05/14] datapath: Don't unnecessarily set skb mac header.

Ben Pfaff blp at nicira.com
Thu Dec 2 23:28:37 UTC 2010


On Thu, Dec 02, 2010 at 12:36:54PM -0800, Jesse Gross wrote:
> We currently call skb_reset_mac_header() in a few places when a
> packet is received.  However, this is not needed because flow_extract()
> will set all of the protocol headers during parsing and nothing needs
> the packet headers before that time.
> 
> Signed-off-by: Jesse Gross <jesse at nicira.com>

I verified that vport_receive() always calls flow_extract() along these
paths, and that flow_extract() always calls skb_reset_mac_header().

Acked-by: Ben Pfaff <blp at nicira.com>




More information about the dev mailing list