[ovs-dev] [PATCH 06/14] tunneling: Fix header parsing for ECN decapsulation.

Ben Pfaff blp at nicira.com
Thu Dec 2 23:45:48 UTC 2010


On Thu, Dec 02, 2010 at 12:36:55PM -0800, Jesse Gross wrote:
> When copying ECN bits from the tunnel header to the inner packet,
> the network header was not being properly located when there was
> a vlan tag.  This simplies and fixes the header parsing to prevent
> this problem.  It also removes a call to eth_type_trans() which
> does several comparisions of MAC addresses which are not needed here
> because we do not need to set skb->pkt_type.

The eth_type_trans() elimination looks good to me, as long as we don't
need the special case for IPX (I sure hope we don't).

In ecn_decapsulate(), we access the IP header (ip_hdr(skb)->tos) before
we check that we can get at it with pskb_may_pull().  That doesn't look
right to me, especially given that we are careful to check that we can
pull an extra 4 bytes when there's an 802.1Q header.




More information about the dev mailing list