[ovs-dev] [tests+nxm-ofctl 32/42] pinsched: Use hmap instead of port_array.

Justin Pettit jpettit at nicira.com
Sun Dec 5 01:04:49 UTC 2010


On Nov 23, 2010, at 2:44 PM, Ben Pfaff wrote:

> +static void
> +pinqueue_destroy(struct pinsched *ps, struct pinqueue *q)
> +{
> +    hmap_remove(&ps->queues, &q->node);
> +    free(q);
> +}

Do you think it's worth mentioning in the comment that the caller is responsible for making sure that the list of packets is empty?

Otherwise, looks good.

--Justin






More information about the dev mailing list