[ovs-dev] [tests+nxm-ofctl 35/42] ofp-util: New functions for creating Nicira extension messages.

[Justin Pettit]

On Nov 23, 2010, at 2:44 PM, Ben Pfaff wrote:

> +/* Creates an stats request message with Nicira as vendor and the given

"an" -> "a"

> + * 'subtype', of total length 'openflow_len'.  Returns the message. */
> +void *
> +ofputil_make_nxstats_request(size_t openflow_len, uint32_t subtype,
> +                             struct ofpbuf **bufferp)
> +{

The return value is inconsistent with ofputil_make_stats_request(), which returns the first byte of the "body" member.  Do you think it's worth modifying nicira_stats_msg to have a "body" member, so they could behave similarly?

Otherwise, looks good.

--Justin