[ovs-dev] [tests+nxm-ofctl 36/42] ofp-util: New abstractions for flow_mod, flow_stats_request.
Justin Pettit
jpettit at nicira.com
Mon Dec 6 22:24:38 UTC 2010
On Nov 23, 2010, at 2:44 PM, Ben Pfaff wrote:
> +int
> +ofputil_decode_flow_stats_request(struct flow_stats_request *fsr,
> + const struct ofp_header *oh,
> + enum nx_flow_format flow_format)
> +{
> ...
> + default:
> + /* Hey, the caller lied. */
> + NOT_REACHED();
You should change this macro to SOAP_PARTY().
> +/* Flow format independent flow stats or aggregate stats request. */
"independent of"?
Otherwise, looks good.
--Justin
More information about the dev
mailing list