[ovs-dev] [nxm-fixes 2/3] nicira-ext: Clarify comments about 'src' and 'dst' in NXAST_REG actions.

Justin Pettit jpettit at nicira.com
Tue Dec 7 03:01:01 UTC 2010


Looks good.

--Justin


On Dec 2, 2010, at 2:22 PM, Ben Pfaff wrote:

> ---
> include/openflow/nicira-ext.h |    9 ++++++---
> 1 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/include/openflow/nicira-ext.h b/include/openflow/nicira-ext.h
> index 56a3195..eb1e862 100644
> --- a/include/openflow/nicira-ext.h
> +++ b/include/openflow/nicira-ext.h
> @@ -347,8 +347,11 @@ OFP_ASSERT(sizeof(struct nx_action_pop_queue) == 16);
>  * bit 'c').  Bit numbering starts at 0 for the least-significant bit, 1 for
>  * the next most significant bit, and so on.
>  *
> - * 'src' and 'dst' are nxm_header values with nxm_hasmask=0.  The following
> - * nxm_header values are potentially acceptable as 'src':
> + * 'src' and 'dst' are nxm_header values with nxm_hasmask=0.  (It doesn't make
> + * sense to use nxm_hasmask=1 because the action does not do any kind of
> + * matching; it uses the actual value of a field.)
> + *
> + * The following nxm_header values are potentially acceptable as 'src':
>  *
>  *   - NXM_OF_IN_PORT
>  *   - NXM_OF_ETH_DST
> @@ -413,7 +416,7 @@ OFP_ASSERT(sizeof(struct nx_action_reg_move) == 24);
>  * starts at 0 for the least-significant bit, 1 for the next most significant
>  * bit, and so on.
>  *
> - * 'dst' must be one of the following:
> + * 'dst' is an nxm_header with nxm_hasmask=0.  It must be one of the following:
>  *
>  *   - NXM_NX_REG(idx) for idx in the switch's accepted range.
>  *
> -- 
> 1.7.1
> 
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev_openvswitch.org





More information about the dev mailing list