[ovs-dev] [tests+nxm-ofctl 36/42] ofp-util: New abstractions for flow_mod, flow_stats_request.

Ben Pfaff blp at nicira.com
Tue Dec 7 20:45:14 UTC 2010


On Mon, Dec 06, 2010 at 02:24:38PM -0800, Justin Pettit wrote:
> On Nov 23, 2010, at 2:44 PM, Ben Pfaff wrote:
> 
> > +int
> > +ofputil_decode_flow_stats_request(struct flow_stats_request *fsr,
> > +                                  const struct ofp_header *oh,
> > +                                  enum nx_flow_format flow_format)
> > +{
> > ...
> > +    default:
> > +        /* Hey, the caller lied. */
> > +        NOT_REACHED();
> 
> You should change this macro to SOAP_PARTY().

I'm not hip to your scene.

> > +/* Flow format independent flow stats or aggregate stats request. */
> 
> "independent of"?
> 
> Otherwise, looks good.

I changed this to:
/* Flow stats or aggregate stats request, independent of flow format. */




More information about the dev mailing list