[ovs-dev] [PATCH 2/2] ofp-print: Print Nicira error extension messages.

Ben Pfaff blp at nicira.com
Thu Dec 9 00:05:18 UTC 2010


On Wed, Dec 08, 2010 at 03:49:18PM -0800, Justin Pettit wrote:
> Currently, Nicira error messages are non-overlapping with the OpenFlow
> error definitions.  This commit takes advantage of that by not taking
> into account the vendor id.  Printing error messages is likely to be
> overhauled before long, and a more general approach can be taken then.

Does anything verify that the error message is long enough?

In the ds_put_hex_dump() call, I would prefer writing "nve + 1" over
"++nve" since nothing actually ever uses the incremented value.

Thanks,

Ben.




More information about the dev mailing list