[ovs-dev] [ofp-print 12/18] ofp-util: Fix byte order of ofputil_cls_rule_from_match() parameter.

Justin Pettit jpettit at nicira.com
Thu Dec 9 01:59:49 UTC 2010


Looks good.

--Justin


On Dec 8, 2010, at 4:27 PM, Ben Pfaff wrote:

> This doesn't change any generated code so it is not a bug fix, but it
> makes the byte order of the 'cookie' argument clear.
> ---
> lib/ofp-util.c |    2 +-
> lib/ofp-util.h |    2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/ofp-util.c b/lib/ofp-util.c
> index aa51333..d9c9dcd 100644
> --- a/lib/ofp-util.c
> +++ b/lib/ofp-util.c
> @@ -105,7 +105,7 @@ void
> ofputil_cls_rule_from_match(const struct ofp_match *match,
>                             unsigned int priority,
>                             enum nx_flow_format flow_format,
> -                            uint64_t cookie, struct cls_rule *rule)
> +                            ovs_be64 cookie, struct cls_rule *rule)
> {
>     struct flow_wildcards *wc = &rule->wc;
>     unsigned int ofpfw;
> diff --git a/lib/ofp-util.h b/lib/ofp-util.h
> index a0c103f..c3ed2b8 100644
> --- a/lib/ofp-util.h
> +++ b/lib/ofp-util.h
> @@ -106,7 +106,7 @@ int ofputil_netmask_to_wcbits(ovs_be32 netmask);
> /* Work with OpenFlow 1.0 ofp_match. */
> void ofputil_cls_rule_from_match(const struct ofp_match *,
>                                  unsigned int priority, enum nx_flow_format,
> -                                 uint64_t cookie, struct cls_rule *);
> +                                 ovs_be64 cookie, struct cls_rule *);
> void ofputil_cls_rule_to_match(const struct cls_rule *, enum nx_flow_format,
>                                struct ofp_match *);
> void normalize_match(struct ofp_match *);
> -- 
> 1.7.1
> 
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev_openvswitch.org





More information about the dev mailing list