[ovs-dev] [PATCH 05/19] tunneling: Update port pools on config change.

Ben Pfaff blp at nicira.com
Thu Dec 9 17:48:07 UTC 2010


On Wed, Dec 08, 2010 at 10:14:03PM -0800, Jesse Gross wrote:
> We keep track of the number of tunnels using the different types of
> matching in order to avoid doing the lookup when there are no ports
> of that type.  However, when updating the configuration we weren't
> changing the port pool counts, which could lead to incorrectly not
> finding a tunnel on receive.
> 
> Signed-off-by: Jesse Gross <jesse at nicira.com>

I think that this still leaves the counters off if the remove succeeds
but the insert fails.

You know, it would be cleaner to just have four "port_table"s instead of
one.  Then we wouldn't need separate counters at all.

(tbl_count() should be inlined though.)




More information about the dev mailing list