[ovs-dev] [PATCH 08/19] datapath: Compatibility code for inet_proto_csum_replace2.

Ben Pfaff blp at nicira.com
Thu Dec 9 18:03:43 UTC 2010


On Wed, Dec 08, 2010 at 10:14:06PM -0800, Jesse Gross wrote:
> Kernels earlier than 2.6.25 did not define inet_proto_csum_replace2,
> so implement it ourselves.
> 
> Signed-off-by: Jesse Gross <jesse at nicira.com>

It would be better as an inline function.  If "from" or "to" is
mistakenly passed as, say, a pointer, then this will silently accept
that (although we'd catch it compiling on a later kernel).

The only actual problem I see with it is that the trailing ; should be
deleted.




More information about the dev mailing list