[ovs-dev] [PATCH 13/19] brcompat: Simplify generation of bridge ID.

Ben Pfaff blp at nicira.com
Thu Dec 9 18:14:22 UTC 2010


On Wed, Dec 08, 2010 at 10:14:11PM -0800, Jesse Gross wrote:
> Currently we use a fairly complicated method of generating the
> bridge ID, since the actual struct is only available in a header
> file private to the Linux bridge.  The current method appears to
> be correct but is difficult to reason about.  This replaces it
> with a simple memcpy, which is more analogous to what the Linux
> bridge does.
> 
> Flagged by sparse.
> 
> Signed-off-by: Jesse Gross <jesse at nicira.com>

The bridge uses default priority 0x8000 as specified by 802.1D, but we
apparently fix priority 0.  But this commit doesn't change that, so:

Acked-by: Ben Pfaff <blp at nicira.com>




More information about the dev mailing list