[ovs-dev] [PATCH 14/19] tunneling: Add missing rcu_dereference() to cache cleaner.

Ben Pfaff blp at nicira.com
Thu Dec 9 18:15:10 UTC 2010


On Wed, Dec 08, 2010 at 10:14:12PM -0800, Jesse Gross wrote:
> The cleaner for the header caching accesses the tunnel port table
> without holding any locks.  However, it doesn't have a read memory
> barrier, so there is no guarantee that the contents of the table
> have made it to the right CPU.
> 
> Found by sparse.
> 
> Signed-off-by: Jesse Gross <jesse at nicira.com>

Wow, I didn't know sparse could find this kind of thing.  It's magic!

Acked-by: Ben Pfaff <blp at nicira.com>




More information about the dev mailing list