[ovs-dev] [PATCH 05/19] tunneling: Update port pools on config change.

Ben Pfaff blp at nicira.com
Thu Dec 9 20:04:19 UTC 2010


On Thu, Dec 09, 2010 at 11:44:14AM -0800, Jesse Gross wrote:
> > You know, it would be cleaner to just have four "port_table"s instead of
> > one.  Then we wouldn't need separate counters at all.
> 
> I guess but I don't really want to do this now since I'm planning to
> change a couple things in this area.  The first is that I'm planning
> on dropping local_ip, which will cut the number of tables in half.
> The second is to migrate away from using our hash table implementation
> at all here and just use the normal kernel hlist.
> 
> The primary benefit to combining things like this is to save memory
> when multiple port types are in use.

OK.

> > (tbl_count() should be inlined though.)
> >
> 
> Probably but it doesn't really matter - it's not used anywhere
> performance critical.  All of the hash table stuff is going to be
> changing soon anyways.

I meant, if we made the change that I was envisioning.

Thanks,

Ben.




More information about the dev mailing list