[ovs-dev] [trace 3/3] ofproto: Add "ofproto/trace" command to help debugging flow tables.

Ben Pfaff blp at nicira.com
Thu Dec 9 22:39:15 UTC 2010


On Thu, Dec 09, 2010 at 02:37:47PM -0800, Ethan Jackson wrote:
> This looks good assuming the resubmit hook from patch 1 of the series
> comes
> back in this patch.

Thanks.

> +    dpname = strtok_r(args, " ", &save_ptr);
> +    tun_id_s = strtok_r(NULL, " ", &save_ptr);
> +    in_port_s = strtok_r(NULL, " ", &save_ptr);
> +    packet_s = strtok_r(NULL, "", &save_ptr);
> The seconds strtok arg for packet_s should probably be " ".

That's intentional actually, I want the whole rest of the string
regardless of what it contains, in case the user wants to separate some
of the hex digits by spaces.

Thanks for the reviews.




More information about the dev mailing list