[ovs-dev] [tunid64 v3 1/8] netlink: Make netlink-protocol.h compatible with <linux/netlink.h>.

Jesse Gross jesse at nicira.com
Thu Dec 9 23:45:54 UTC 2010


On Thu, Dec 9, 2010 at 2:48 PM, Ben Pfaff <blp at nicira.com> wrote:
> Until now, netlink-protocol.h and <linux/netlink.h> could not both be
> included by a single source file, because they contained conflicting
> definitions.  This commit fixes the problem, by having netlink-protocol.h
> delegate to <linux/netlink.h> where it is available.
>
> Here's an example of the problem: odp-util.c includes both
> datapath-protocol.h and will need netlink-protocol.h also so that it can
> look through actions defined as struct nlattr.  datapath-protocol.h
> includes <linux/if_link.h> for the definition of rtnl_link_stats64, and
> <linux/if_link.h> includes <linux/netlink.h>.

I'm OK with the changes in this file now.  However, I believe we still
need to change automake.mk so that the Netlink helper files get
compiled when !HAVE_NETLINK on non-Linux platforms.

Otherwise:
Acked-by: Jesse Gross <jesse at nicira.com>




More information about the dev mailing list