[ovs-dev] [tunid64 v3 5/8] datapath: Replace "struct odp_action" by Netlink attributes.

Jesse Gross jesse at nicira.com
Fri Dec 10 00:20:40 UTC 2010


On Thu, Dec 9, 2010 at 2:48 PM, Ben Pfaff <blp at nicira.com> wrote:
>  static int do_answer_query(struct sw_flow *flow, u32 query_flags,
>                           struct odp_flow_stats __user *ustats,
> -                          union odp_action __user *actions,
> -                          u32 __user *n_actionsp)
> +                          struct nlattr __user *actions,
> +                          unsigned int __user *actions_lenp)

I guess I was expecting that the things using actions_len would also
change from unsigned int to u32/uint32_t, at least at the interface
boundaries.  int is such an ambiguously defined type, it doesn't make
sense to to me to use it, even if in practice we should be safe.  It's
also inconsistent: all of our other structures and all of the Linux
interfaces use explicitly sized types.




More information about the dev mailing list