[ovs-dev] [tunid64 v3 5/8] datapath: Replace "struct odp_action" by Netlink attributes.

Jesse Gross jesse at nicira.com
Fri Dec 10 19:00:06 UTC 2010


On Fri, Dec 10, 2010 at 10:41 AM, Ben Pfaff <blp at nicira.com> wrote:
> On Thu, Dec 09, 2010 at 04:20:40PM -0800, Jesse Gross wrote:
>> On Thu, Dec 9, 2010 at 2:48 PM, Ben Pfaff <blp at nicira.com> wrote:
>> >  static int do_answer_query(struct sw_flow *flow, u32 query_flags,
>> >                           struct odp_flow_stats __user *ustats,
>> > -                          union odp_action __user *actions,
>> > -                          u32 __user *n_actionsp)
>> > +                          struct nlattr __user *actions,
>> > +                          unsigned int __user *actions_lenp)
>>
>> I guess I was expecting that the things using actions_len would also
>> change from unsigned int to u32/uint32_t, at least at the interface
>> boundaries.  int is such an ambiguously defined type, it doesn't make
>> sense to to me to use it, even if in practice we should be safe.  It's
>> also inconsistent: all of our other structures and all of the Linux
>> interfaces use explicitly sized types.
>
> OK, I went through and changed all of the datapath/ files to use u32
> consistently.  Here's the updated version in case you want to check my
> work.

Thanks.

Acked-by: Jesse Gross <jesse at nicira.com>




More information about the dev mailing list