[ovs-dev] [PATCH 3/5] datapath: Drop synchronize_rcu() in internal dev destroy.

Ben Pfaff blp at nicira.com
Fri Dec 10 22:58:29 UTC 2010


On Fri, Dec 10, 2010 at 12:42:55PM -0800, Jesse Gross wrote:
> unregister_device() contains a call to synchronize_rcu(), so there

unregister_netdevice() that is.

> is no need to directly call it ourselves immediately beforehand.
> We were relying on the call during unregistration anyways to stop
> packets from being transmited on the device, so our version was
> both misleading and had a performance penalty.
> 
> Signed-off-by: Jesse Gross <jesse at nicira.com>

Good catch, thanks.

Acked-by: Ben Pfaff <blp at nicira.com>




More information about the dev mailing list