[ovs-dev] [PATCH 4/5] datapth: Drop check for impossible condition after skb_gso_segment().

Ben Pfaff blp at nicira.com
Fri Dec 10 23:01:41 UTC 2010


On Fri, Dec 10, 2010 at 12:42:56PM -0800, Jesse Gross wrote:
> It's possible for skb_gso_segment to return NULL but only if the
> hardware supports the correct form of segmentation offload but just
> wants software to verify the offload parameters.  However, since we're
> not hardware and don't support any kind of segmentation offload natively,
> we can never get in this situation.  Therefore drop the check and
> comment.
> 
> Signed-off-by: Jesse Gross <jesse at nicira.com>

Ah, so *that's* what the comment on skb_gso_segment() means.  It all
makes sense now.  Thanks.

Acked-by: Ben Pfaff <blp at nicira.com>




More information about the dev mailing list