[ovs-dev] [PATCH] ofproto: Fix problem that caused facets not to be installed into datapath.

Justin Pettit jpettit at nicira.com
Sat Dec 11 04:57:02 UTC 2010


Commit cdee00f (datapath: Replace "struct odp_action" by Netlink
attributes.) stopped setting the "may_install" bool in facet structures
in some cases.  This caused flows to not be installed into the datapath.
This commit sets that again based on the action context.
---
 ofproto/ofproto.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
index 339b960..09f6722 100644
--- a/ofproto/ofproto.c
+++ b/ofproto/ofproto.c
@@ -2250,6 +2250,7 @@ facet_make_actions(struct ofproto *p, struct facet *facet,
 
     action_xlate_ctx_init(&ctx, p, &facet->flow, packet);
     odp_actions = xlate_actions(&ctx, rule->actions, rule->n_actions);
+    facet->may_install = ctx.may_set_up_flow;
 
     if (facet->actions_len != odp_actions->size
         || memcmp(facet->actions, odp_actions->data, odp_actions->size)) {
-- 
1.7.1





More information about the dev mailing list