[ovs-dev] [PATCH] ofproto: Fix problem that caused facets not to be installed into datapath.

Ben Pfaff blp at nicira.com
Sat Dec 11 05:39:45 UTC 2010


On Fri, Dec 10, 2010 at 8:57 PM, Justin Pettit <jpettit at nicira.com> wrote:
> Commit cdee00f (datapath: Replace "struct odp_action" by Netlink
> attributes.) stopped setting the "may_install" bool in facet structures
> in some cases.  This caused flows to not be installed into the datapath.
> This commit sets that again based on the action context.

This fix looks correct as far as it goes, but shouldn't it also restore
the assignments to facet->tags and facet->nf_flow.output_iface?

Thanks,

Ben.




More information about the dev mailing list