[ovs-dev] [PATCH] ofproto: Fix problem that caused facets not to be installed into datapath.

Justin Pettit jpettit at nicira.com
Sat Dec 11 06:28:39 UTC 2010


On Dec 10, 2010, at 9:39 PM, Ben Pfaff wrote:

> On Fri, Dec 10, 2010 at 8:57 PM, Justin Pettit <jpettit at nicira.com> wrote:
>> Commit cdee00f (datapath: Replace "struct odp_action" by Netlink
>> attributes.) stopped setting the "may_install" bool in facet structures
>> in some cases.  This caused flows to not be installed into the datapath.
>> This commit sets that again based on the action context.
> 
> This fix looks correct as far as it goes, but shouldn't it also restore
> the assignments to facet->tags and facet->nf_flow.output_iface?

Well, there goes my plan to spread this out as three separate commits.  (I need to work on my Ubuntu karma, man!)

Thanks.  I fixed those and pushed.

--Justin






More information about the dev mailing list