[ovs-dev] [PATCH 1/2] datapath: Compatibility code for __packed macro.

Jesse Gross jesse at nicira.com
Mon Dec 13 18:13:17 UTC 2010


On Mon, Dec 13, 2010 at 9:22 AM, Ben Pfaff <blp at nicira.com> wrote:
> On Sun, Dec 12, 2010 at 12:49:39PM -0800, Jesse Gross wrote:
>> The __packed macro for structure packing wasn't introduced until 2.6.24,
>> so define it ourselves.
>>
>> Signed-off-by: Jesse Gross <jesse at nicira.com>
>
> Acked-by: Ben Pfaff <blp at nicira.com>
>
> Nits:
>
> Is the #ifndef necessary?  Won't the #include_next take care of that anyway?

The #include_next will take care of the #ifndef on current kernels.
Older ones have a comment to that effect but no check.

>
> I always add include guards habitually, even when they are not
> necessary.  I don't care that much, though.

The original Linux source file doesn't have any guards - just a check
that compiler.h was included already, which acts as its guard.  I kept
it the same for consistency.




More information about the dev mailing list