[ovs-dev] [PATCH 5/5] datapath-protocol: Include netlink.h.

Jesse Gross jesse at nicira.com
Mon Dec 13 19:13:53 UTC 2010


On Mon, Dec 13, 2010 at 10:33 AM, Ben Pfaff <blp at nicira.com> wrote:
> On Sun, Dec 12, 2010 at 12:47:07PM -0800, Jesse Gross wrote:
>> On older kernels that don't have if_link.h, we use our own, limited
>> version.  This version doesn't include the netlink header, causing
>> problems where we were relying on it to define the types in
>> datapath-protocol.h.  Therefore, directly include it, since it is
>> better to be explicit about it anyways.
>
> I agree with this patch.
>
> Should our if_link.h include netlink.h, since the kernel version does.

It's probably a good idea.  I added it in addition to including it in
datapath-protocol.h, since we directly use the netlink attributes
there.

>
> It might be good to sign this off, since it is needed by kernel code.

Also a good idea.




More information about the dev mailing list