[ovs-dev] [PATCH 2/5] vswitchd: Consistently use size_t for action lengths.

Ben Pfaff blp at nicira.com
Mon Dec 13 19:18:15 UTC 2010


On Mon, Dec 13, 2010 at 11:11:57AM -0800, Jesse Gross wrote:
> On Mon, Dec 13, 2010 at 10:29 AM, Ben Pfaff <blp at nicira.com> wrote:
> > On Sun, Dec 12, 2010 at 12:47:04PM -0800, Jesse Gross wrote:
> >> Currently the type of the datapath action length is mixture of
> >> size_t and unsigned int.  However, size_t is really defined as an
> >> unsigned long, which causes the build to fail on 64-bit platforms.
> >> This consistently uses size_t.
> >
> > Seems reasonable, but what kind of build failure do you get?  The usual
> > reason would be for mixing integer types as the targets of pointers, but
> > I don't see any pointers involved in any of these changes.
> 
> The build failure was due to a function prototype using one type and
> the definition using the other, which the compiler did not like very
> much.
> 
> There were also several warnings about incompatible pointer types
> where one type was used as an argument in a function that was used as
> a function pointer that didn't match the pointer type.

OK, that makes sense, thank you.




More information about the dev mailing list