[ovs-dev] [PATCH] nicira-ext: Correct and extend examples for NXM_OF_VLAN_TCI field.

Justin Pettit jpettit at nicira.com
Mon Dec 13 21:18:26 UTC 2010


Looks good.

--Justin


On Dec 13, 2010, at 1:15 PM, Ben Pfaff wrote:

> The final example for this field was wrong.  This corrects it and adds
> two more examples.
> 
> Reported-by: Natasha Gude <natasha at nicira.com>
> ---
> I thought that I sent this one out a long time ago, but I couldn't find
> it in my email archive when I looked, and it still applies.
> 
> diff --git a/include/openflow/nicira-ext.h b/include/openflow/nicira-ext.h
> index 135f793..cdccb30 100644
> --- a/include/openflow/nicira-ext.h
> +++ b/include/openflow/nicira-ext.h
> @@ -761,8 +761,14 @@ OFP_ASSERT(sizeof(struct nx_action_note) == 16);
>  *   - Testing with a specific PCP and CFI=1, with nxm_mask=0xf000, matches
>  *     packets that have an 802.1Q header with that PCP (and any VID).
>  *
> - *   - Testing with nxm_value=0, nxm_mask=0xe000 matches packets with no 802.1Q
> + *   - Testing with nxm_value=0, nxm_mask=0x0fff matches packets with no 802.1Q
>  *     header or with an 802.1Q header with a VID of 0.
> + *
> + *   - Testing with nxm_value=0, nxm_mask=0xe000 matches packets with no 802.1Q
> + *     header or with an 802.1Q header with a PCP of 0.
> + *
> + *   - Testing with nxm_value=0, nxm_mask=0xefff matches packets with no 802.1Q
> + *     header or with an 802.1Q header with both VID and PCP of 0.
>  */
> #define NXM_OF_VLAN_TCI   NXM_HEADER  (0x0000,  4, 2)
> #define NXM_OF_VLAN_TCI_W NXM_HEADER_W(0x0000,  4, 2)
> -- 
> 1.7.1
> 
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev_openvswitch.org





More information about the dev mailing list