[ovs-dev] [PATCH] Makefile: Check for undistributed files on every make, not just "make dist".

Ben Pfaff blp at nicira.com
Mon Dec 13 22:31:48 UTC 2010


On Mon, Dec 13, 2010 at 02:19:32PM -0800, Justin Pettit wrote:
> On Dec 6, 2010, at 11:33 AM, Ben Pfaff wrote:
> 
> > +CLEANFILES += all-distfiles all-gitfiles missing-distfiles
> > +# The following is based on commands for the Automake "distdir" target.
> > +distfiles: Makefile
> > +	srcdirstrip=`echo "$(srcdir)" | sed 's/[].[^$$\\*]/\\\\&/g'`; \
> > +	topsrcdirstrip=`echo "$(top_srcdir)" | sed 's/[].[^$$\\*]/\\\\&/g'`; \
> > +	list='$(DISTFILES)'; \
> > +	for file in $$list; do echo $$file; done | \
> > +	  sed -e "s|^$$srcdirstrip/||;t" \
> > +	      -e "s|^$$topsrcdirstrip/|$(top_builddir)/|;t" | sort -u > $@
> > +CLEANFILES += distfiles
> ...
> > diff --git a/datapath/Makefile.am b/datapath/Makefile.am
> > index 71e2dc4..1c0af40 100644
> > --- a/datapath/Makefile.am
> > +++ b/datapath/Makefile.am
> > 
> > +# The following is based on commands for the Automake "distdir" target.
> > +distfiles: Makefile
> > +	@srcdirstrip=`echo "$(srcdir)" | sed 's/[].[^$$\\*]/\\\\&/g'`; \
> > +	topsrcdirstrip=`echo "$(top_srcdir)" | sed 's/[].[^$$\\*]/\\\\&/g'`; \
> > +	list='$(DISTFILES)'; \
> > +	for file in $$list; do echo $$file; done | \
> > +	  sed -e "s|^$$srcdirstrip/||;t" \
> > +	      -e "s|^$$topsrcdirstrip/|$(top_builddir)/|;t" | sort -u > $@
> > +CLEANFILES = distfiles
> 
> For consistency, do you want to prepend that first "srcdirstrip" line
> with an "@"?

Might as well, thanks.




More information about the dev mailing list