[ovs-dev] [PATCH] datapath: Correctly return error if percpu allocation fails.

Jesse Gross jesse at nicira.com
Mon Dec 13 23:32:04 UTC 2010


If the allocation of percpu stats fails when creating a new
datapath, we currently don't return the correct error code.  Since
we don't explicitly set it when the allocation fails it will keep
the value from the previous call.  This means we will return success
when the creation actually failed.

Signed-off-by: Jesse Gross <jesse at nicira.com>
---
 datapath/datapath.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/datapath/datapath.c b/datapath/datapath.c
index 0205fd2..fded95c 100644
--- a/datapath/datapath.c
+++ b/datapath/datapath.c
@@ -270,8 +270,10 @@ static int create_dp(int dp_idx, const char __user *devnamep)
 
 	dp->drop_frags = 0;
 	dp->stats_percpu = alloc_percpu(struct dp_stats_percpu);
-	if (!dp->stats_percpu)
+	if (!dp->stats_percpu) {
+		err = -ENOMEM;
 		goto err_destroy_local_port;
+	}
 
 	rcu_assign_pointer(dps[dp_idx], dp);
 	dp_sysfs_add_dp(dp);
-- 
1.7.1





More information about the dev mailing list