[ovs-dev] [PATCH] datapath: Correctly return error if percpu allocation fails.

Ben Pfaff blp at nicira.com
Mon Dec 13 23:38:48 UTC 2010


On Mon, Dec 13, 2010 at 03:32:04PM -0800, Jesse Gross wrote:
> If the allocation of percpu stats fails when creating a new
> datapath, we currently don't return the correct error code.  Since
> we don't explicitly set it when the allocation fails it will keep
> the value from the previous call.  This means we will return success
> when the creation actually failed.
> 
> Signed-off-by: Jesse Gross <jesse at nicira.com>

Good catch, thanks.

(I suspect that sometime in the distant past this allocation was just
after some other allocation that had already set err to -ENOMEM.)

Acked-by: Ben Pfaff <blp at nicira.com>




More information about the dev mailing list