[ovs-dev] [PATCH] openvswitch init script modifications for kvm and lxc hosts

[Ben Pfaff]

On Mon, Dec 13, 2010 at 05:49:46PM -0500, Patrick Mullaney wrote:
> Signed-off-by: Patrick Mullaney <pm.mullaney at gmail.com>

Thank you for the patch.  Most of this looks pretty good.  I have some
questions and comments.

The /etc/sysconfig/openvswitch added by this patch conflicts with the
one that the init script already expects to find, which is generated
on XenServer from the template that is included as
xenserver/usr_share_openvswitch_scripts_sysconfig.template.  

It would make sense to add $NETWORK_MODE to that template, if it is
needed on SuSE.  Is it needed?  (It is used on XenServer because it has
two different modes of operations, one that uses OVS, one that uses the
Linux bridge.)  Would it make sense to name it something different,
e.g. ENABLE_OVS?

It doesn't make sense to install etc_init.d_openvswitch-xapi-update on
SuSE at all, since it will at most print an error message and exit with
status 1.  So it seems unnecessary to modify that file.

Thanks,

Ben.