[ovs-dev] [PATCH 2/2] datapath: Harmonize [get|set]_skb_csum_pointers().

Ben Pfaff blp at nicira.com
Thu Dec 16 17:35:47 UTC 2010


On Wed, Dec 15, 2010 at 08:15:59PM -0800, Jesse Gross wrote:
> The functions to get and set the checksum pointers consistently across
> different kernel versions had different interpretations of what the
> csum_offset pointer was relative to, which is confusing, to say the least.
> This makes the meaning be the same as skb->csum_offset in modern kernels
> and updates the callers.  For a given function the results were consistent
> across kernel versions and the callers knew what the meaning should be, so
> this doesn't actually fix any bugs.
> 
> Signed-off-by: Jesse Gross <jesse at nicira.com>

I found the "updates the callers" part of the paragraph above a bit
confusing because the patch only updates one caller.  But as it turns
out, there's only one anyway.

If you s/(updates the caller)s/\1/ then:
Acked-by: Ben Pfaff <blp at nicira.com>




More information about the dev mailing list