[ovs-dev] [PATCH] odp-util: Correct length check in format_odp_action().

Jesse Gross jesse at nicira.com
Thu Dec 16 22:43:24 UTC 2010


On Thu, Dec 16, 2010 at 2:39 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Thu, Dec 16, 2010 at 02:33:51PM -0800, Jesse Gross wrote:
>> When printing the action list we first check that the size of the
>> action matches the expected length for that type.  However, when
>> doing the lookup we were passing in the length of the action, not
>> the type, leading to bogus values.
>
> Oops.  Thanks for the fix.
>
> This seems obviously correct, but I wonder why it took this long to be
> discovered.

Output is by far the most common action and it just happens to work in
that case: the size of the output action corresponds to the type of
another action that has the same length as output.

I pushed this.




More information about the dev mailing list