[ovs-dev] [PATCH 4/6] vswitch: Use "ipsec_gre" vport instead of "gre" with "other_config"

Jesse Gross jesse at nicira.com
Thu Dec 23 09:43:00 UTC 2010


On Wed, Dec 22, 2010 at 9:17 PM, Justin Pettit <jpettit at nicira.com> wrote:
> On Dec 22, 2010, at 3:29 PM, Jesse Gross wrote:
>>> diff --git a/lib/odp-util.c b/lib/odp-util.c
>>> index e1ea976..8aeb98d 100644
>>> --- a/lib/odp-util.c
>>> +++ b/lib/odp-util.c
>>> @@ -220,6 +220,7 @@ void
>>>  format_odp_port_type(struct ds *ds, const struct odp_port *p)
>>>  {
>>>     if (!strcmp(p->type, "gre")
>>> +            || !strcmp(p->type, "ipsec_gre")
>>>             || !strcmp(p->type, "capwap")) {
>>>         struct tnl_port_config config;
>>
>> This won't properly translate the type to ipsec_gre.
>
> Why not?  It's already been switched from "gre" with TNL_F_IPSEC set to "ipsec_gre".  Maybe I'm not understanding what you're saying...

Never mind, that was my mistake.  I was thinking that this was coming
directly from the kernel but in reality, it has gone through the
translation layer in dpif-linux.




More information about the dev mailing list