[ovs-dev] [PATCH] lib: Fix compiler warnings on x86_64

Ben Pfaff blp at nicira.com
Mon Dec 27 17:40:44 UTC 2010


This patch mixes together a lot of different stuff.  I'd prefer to see
it broken apart.

I don't understand what difference the change to lib/multipath.c would
make.  What warning does it suppress, for example?  I don't see why it
would be x86-64 specific, are you sure that this isn't a GCC version
issue?  (What GCC version are you using again?)

The str_to_action() change looks like just a plain bug.  I wouldn't lump
an actual bug in with fixes for harmless warnings.

Why did you change minLen and maxLen to unsigned long long int?  I don't
understand what this would fix.  OVSDB is not going to survive someone
creating a string longer than 4 GB--its performance would be
unacceptably bad.

In stream-ssl, the correct format specifier for size_t is %zu, not %Zu.
(The GNU libc manual says: "`Z' is a GNU extension predating [`z'] and
should not be used in new code.")

Thanks,

Ben.




More information about the dev mailing list