[ovs-dev] [PATCH 2/2] Implement database schema versioning.
Ben Pfaff
blp at nicira.com
Mon Dec 27 22:26:31 UTC 2010
On Mon, Dec 27, 2010 at 01:43:49PM -0800, Justin Pettit wrote:
> On Dec 22, 2010, at 12:51 PM, Ben Pfaff wrote:
>
> > @@ -1344,6 +1352,7 @@ do_help(int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
> > static const struct command all_commands[] = {
> > { "list-dbs", 1, 1, do_list_dbs },
> > { "get-schema", 2, 2, do_get_schema },
> > + { "get-schema-version", 2, 2, do_get_schema_version },
> > { "list-tables", 2, 2, do_list_tables },
> > { "list-columns", 2, 3, do_list_columns },
> > { "transact", 2, 2, do_transact },
>
> Did you want to add "get-schema-version" to the usage output?
Thanks, I forgot. Fixed.
> > - $vsctl --no-wait --timeout=5 init
> > + $vsctl --no-wait --timeout=5 init -- set Open_vSwitch . db-version="$schemaver"
>
> For ease of grep'ing, do you think it's worth using "_" instead of "-"
> in "db-version"?
The precedent elsewhere in this file seems to be to use "-" in
preference to "_". I wonder whether it was a mistake to allow both from
the beginning.
Thanks,
Ben.
More information about the dev
mailing list