[ovs-dev] [sparse 0/4] fix sparse complaints

Ben Pfaff blp at nicira.com
Mon Dec 27 23:38:09 UTC 2010


This series fixes various issues that sparse complained about.  None
of them is a bug fix, but all of them seemed worth fixing.

There is one remaining possibly interesting complaint that I did not
fix, because I was not certain enough that the code was correct as
written.  Jesse, I'll leave that one to you:

tunnel.c:915:30: warning: symbol 'vport' shadows an earlier one
tunnel.c:860:38: originally declared here

Thanks,

Ben.

Ben Pfaff (4):
  datapath: Remove shadowed 'err' variable.
  datapath: Fix type of actions_len_left in modify_vlan_tci().
  datapath: Suppress sparse complaints about address spaces.
  datapath: Do not shadow 'err' variable name in tnl_send().

 datapath/actions.c  |    3 +--
 datapath/datapath.c |   12 ++++++------
 datapath/tunnel.c   |    6 +++---
 3 files changed, 10 insertions(+), 11 deletions(-)





More information about the dev mailing list