[ovs-dev] [sparse 0/4] fix sparse complaints

Jesse Gross jesse at nicira.com
Tue Dec 28 05:14:50 UTC 2010


On Mon, Dec 27, 2010 at 6:38 PM, Ben Pfaff <blp at nicira.com> wrote:
> This series fixes various issues that sparse complained about.  None
> of them is a bug fix, but all of them seemed worth fixing.

Hmm, I guess that I should turn up the warning level when I run sparse.

>
> There is one remaining possibly interesting complaint that I did not
> fix, because I was not certain enough that the code was correct as
> written.  Jesse, I'll leave that one to you:
>
> tunnel.c:915:30: warning: symbol 'vport' shadows an earlier one
> tunnel.c:860:38: originally declared here

Sure, I'll send out a patch for that shortly.

Thanks all of these look good to me:
Acked-by: Jesse Gross <jesse at nicira.com>




More information about the dev mailing list