[ovs-dev] [PATCH] tunneling: Don't shadow vport when generating cache.

Jesse Gross jesse at nicira.com
Tue Dec 28 17:39:33 UTC 2010


On Tue, Dec 28, 2010 at 12:34 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Mon, Dec 27, 2010 at 09:26:44PM -0800, Jesse Gross wrote:
>> When generating the tunnel header cache we have two vports that we
>> are working with: the sender and destination.  Unfortunately, both of
>> these use the name 'vport'.  This renames the destination to avoid
>> shadowing the sender.  This doesn't actually fix a bug because the
>> compiler correctly uses the right one, even when shadowed.
>>
>> Found with sparse.
>>
>> Reported-by: Ben Pfaff <blp at nicira.com>
>> Signed-off-by: Jesse Gross <jesse at nicira.com>
>
> Acked-by: Ben Pfaff <blp at nicira.com>

Pushed, thanks.




More information about the dev mailing list