[ovs-dev] [PATCH 6/7] datapath: Convert odp_flow_key to use Netlink attributes instead.

[Ben Pfaff]

On Tue, Dec 28, 2010 at 04:48:23PM -0500, Jesse Gross wrote:
> On Tue, Dec 28, 2010 at 2:06 PM, Ben Pfaff <blp at nicira.com> wrote:
> > On Tue, Dec 28, 2010 at 02:13:47AM -0500, Jesse Gross wrote:
> >> > diff --git a/lib/flow.h b/lib/flow.h
> >> > index ee460e3..bbf35c7 100644
> >> > --- a/lib/flow.h
> >> > +++ b/lib/flow.h
> >> > @@ -35,6 +35,10 @@ struct ofpbuf;
> >> >  #define FLOW_N_REGS 4
> >> >  BUILD_ASSERT_DECL(FLOW_N_REGS <= NXM_NX_MAX_REGS);
> >> >
> >> > +/* Used for struct flow's dl_type member for frames that have no Ethernet
> >> > + * type, that is, pure 802.2 frames. */
> >> > +#define FLOW_DL_TYPE_NONE 0
> >>
> >> OpenFlow uses 0x05ff to represent this.  Does it get translated anywhere?
> >
> > Yes, odp_flow_key_{to,from}_flow do the translation correctly.
> 
> Right, I agree that the kernel/userspace translation looks fine.  I
> was wondering about userspace/OpenFlow.

Oops, you're right, there's missing translation there.

I changed ofputil_cls_rule_{to,from}_match and the corresponding
nx_match functions to do the right thing now.