[ovs-dev] [PATCH 05/10] datapath: Fix table sparse annotations.

Ben Pfaff blp at nicira.com
Wed Dec 29 18:01:10 UTC 2010


On Tue, Dec 28, 2010 at 08:50:43PM -0800, Jesse Gross wrote:
> Several of the pointers in table.c were missing the correct
> __rcu annotation and the pointer type in the actual declaration
> of struct tbl was incorrect, so this fixes that.  It also adds
> usage of rcu_dereference() to access an RCU protected pointer,
> which is not strictly correct since an update side lock should
> be held.  However, since the table is used in different pieces
> of code and therefore different locks are used it is difficult
> to know which lock to check without threading the information
> though, which is ugly.  Since other places in table.c have this
> same problem and this code should go away in the future it is
> left as is.
> 
> Found with sparse.
> 
> Signed-off-by: Jesse Gross <jesse at nicira.com>

I verified that the changes in annotations would have no effect on
correctness.  I didn't verify that the annotations were correct (because
these things always confuse me anyway).

Acked-by: Ben Pfaff <blp at nicira.com>




More information about the dev mailing list