[ovs-dev] [PATCH 06/10] tunnel: Drop spinlock around cache free.

Ben Pfaff blp at nicira.com
Wed Dec 29 18:02:30 UTC 2010


On Tue, Dec 28, 2010 at 08:50:44PM -0800, Jesse Gross wrote:
> We hold a spinlock when freeing the cache, since you're generally
> supposed to do that when writing to RCU protected data.  However,
> there's really no point in doing that here because the port has
> already been removed from both the transmit and receive side
> data structures and we've waited for an RCU grace period.  In
> addition, we're about to free the port itself, which contains the
> spinlock and will be in trouble if anyone else is trying to
> access it.  For clarity, drop the spinlock.
> 
> Signed-off-by: Jesse Gross <jesse at nicira.com>

Acked-by: Ben Pfaff <blp at nicira.com>




More information about the dev mailing list