[ovs-dev] [PATCH 10/10] datapath: Use local variable for freeing on flow put error.

Ben Pfaff blp at nicira.com
Wed Dec 29 18:21:31 UTC 2010


On Tue, Dec 28, 2010 at 08:50:48PM -0800, Jesse Gross wrote:
> If inserting a flow failed and we need to free the actions, we
> currently directly free them from the flow struct.  This is fine
> but it makes sparse complain about directly accessing an RCU
> protected field.  We could insert some casts to avoid this but
> it's cleaner to just free the data from the local variable
> instead.
> 
> Found with sparse.
> 
> Signed-off-by: Jesse Gross <jesse at nicira.com>

Acked-by: Ben Pfaff <blp at nicira.com>




More information about the dev mailing list