[ovs-dev] [PATCH 03/10] datapath: Add get_vport_protected().

Ben Pfaff blp at nicira.com
Wed Dec 29 18:27:29 UTC 2010


On Wed, Dec 29, 2010 at 01:24:50PM -0500, Jesse Gross wrote:
> On Wed, Dec 29, 2010 at 12:55 PM, Ben Pfaff <blp at nicira.com> wrote:
> > On Tue, Dec 28, 2010 at 08:50:41PM -0800, Jesse Gross wrote:
> >> In some places we access the array of datapath ports without
> >> RCU protection.  This introduces a new function to check that in
> >> these case the dp mutex is held for protection.
> >>
> >> Found with sparse.
> >>
> >> Signed-off-by: Jesse Gross <jesse at nicira.com>
> >
> > I still don't see how dp->mutex is held inside do_destroy_dp().
> > Probably I am missing something.
> 
> Obviously the same issue as with the previous patch.  Since the
> annotations are correct, I'm going to push this series out when it is
> ready and then work on that.

Obviously, and for completeness you can have:
Acked-by: Ben Pfaff <blp at nicira.com>




More information about the dev mailing list